-
Notifications
You must be signed in to change notification settings - Fork 16
Introduce indexing metadata context data model #1997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
tk-o
wants to merge
17
commits into
main
Choose a base branch
from
feat/indexing-metadata-context
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
4b125d0
Introduce `IndexingMetadataContext` data model to ENSNode SDK
tk-o dcad533
Create `init*` functions for running event handlers preconditions
tk-o a5a8bd6
Execute `migrateEnsNodeSchema` from inside of `initIndexingSetup` fun…
tk-o c57c2ac
Use `EnsIndexerStackInfo` for `stackInfo` field in `IndexingMetadataC…
tk-o a28b0de
Add `getIndexingMetadataContext` method to `EnsDbReader` class
tk-o e91bd13
Add `upsertIndexingMetadataContext` method to `EnsDbWriter` class
tk-o 8892dd5
Update `EnsDbWriterWorker` class to serve a new limited role
tk-o ee1190e
Fix ponder build issue
tk-o 4954e21
Fix typos
tk-o 2f8532e
Implement full tasks sequence for `initIndexingOnchainEvents`
tk-o 361e99d
Merge `initIndexingSetup` function into `initIndexingOnchainEvents`
tk-o 7595a41
Update unit tests
tk-o 1902bfb
Use `getIndexingMetadataContext` for all ENSNode Metadata reads from …
tk-o 6bda3d6
Merge remote-tracking branch 'origin/main' into feat/indexing-metadat…
tk-o e3ddda0
Simplify `EnsDbReader` class and `EnsDbWriter` class
tk-o 4684fb4
Fix tests
tk-o 1ff960e
Apply AI PR feedback
tk-o File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial
Prefer a runtime assertion over the bare type cast.
deserializeIndexingMetadataContext(...)returns a union, and theas IndexingMetadataContextInitializedcast silently lies if the deserializer ever produces a non-initialized variant (e.g., due to a future shape change in the fixture). A small invariant check (e.g.,if (deserialized.statusCode !== IndexingMetadataContextStatusCodes.Initialized) throw new Error(...)) makes the test fail loudly at the fixture rather than at an assertion deep insidebuildConfigFromEnvironment.🤖 Prompt for AI Agents