Re-enable ActiveRecord lock! functionality#54
Open
alexagranov wants to merge 1 commit intonamick:masterfrom
Open
Re-enable ActiveRecord lock! functionality#54alexagranov wants to merge 1 commit intonamick:masterfrom
lock! functionality#54alexagranov wants to merge 1 commit intonamick:masterfrom
Conversation
Author
|
@namick CI is failing due to broken 1.9.3 build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lockjust delegates tolock!so adding a spec showing thatActiveRecord::Locking::Pessimistic#lock!is broken.The problem is in the reimplementation of
reloadwhich callslockbut this returns a Relation not the ActiveRecord class so the overriddenfind(*args)that can handle{no_obfuscated_id: true}never gets called.I went with just removing the options hash from the call to
Relation#findas it doesn't appear it would be used while locking anyway.