Fix issue #8: add production readiness health checks#12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/readyreadiness endpoint that returns 503 when Postgres is unavailable while keeping/healthas HTTP-200 liveness/healthzendpoint/ready+/healthzValidation
make doctormake checkTEST_DATABASE_URL=postgresql://opengithub:opengithub@localhost:55433/opengithub_test ./hack/cargo_locked.sh test -p opengithub-api --test health_readiness --test api_rate_limits_contractcd web && npx vitest run tests/healthz-route.test.tsbash -n scripts/deploy.shpython -m json.tool deploy/aws/health-checks.json >/dev/nullNote
make testwas attempted and reached an unrelated existing failure inprojects_list_contractexpecting/owner/projects/...while implementation returned/orgs/owner/projects/...; readiness-focused tests are green.Closes #8