Skip to content

Update nuspec files to place libraries under .NETnanoFramework1.0 TFM#416

Merged
josesimoes merged 2 commits intodevelopfrom
copilot/update-nuspec-library-location
Mar 11, 2026
Merged

Update nuspec files to place libraries under .NETnanoFramework1.0 TFM#416
josesimoes merged 2 commits intodevelopfrom
copilot/update-nuspec-library-location

Conversation

Copy link

Copilot AI commented Mar 11, 2026

nuspec files were placing output files directly under lib/ without a TFM subfolder, and declaring flat dependencies instead of a framework-targeted dependency group.

Changes across all 9 nuspec files

  • Dependency group: Wrapped all <dependency> elements in <group targetFramework=".NETnanoFramework1.0">
  • File target path: Changed from lib\AssemblyName.ext (per-file) to lib\netnano1.0 (TFM folder)
  • Wildcard pattern: Replaced 5 explicit file entries (.dll, .pdb, .pdbx, .pe, .xml) with a single wildcard

Before:

<dependencies>
  <dependency id="nanoFramework.CoreLibrary" version="2.0.0-preview.33" />
  ...
</dependencies>
...
<files>
  <file src="nanoFramework.M5Core\bin\Release\nanoFramework.M5Core.dll" target="lib\nanoFramework.M5Core.dll" />
  <file src="nanoFramework.M5Core\bin\Release\nanoFramework.M5Core.pdbx" target="lib\nanoFramework.M5Core.pdbx" />
  <!-- ... 3 more explicit entries -->
</files>

After:

<dependencies>
  <group targetFramework=".NETnanoFramework1.0">
    <dependency id="nanoFramework.CoreLibrary" version="2.0.0-preview.33" />
    ...
  </group>
</dependencies>
...
<files>
  <file src="nanoFramework.M5Core\bin\Release\nanoFramework.M5Core.*" target="lib\netnano1.0" />
</files>

Affected packages: M5Core, M5Core2, M5StickC, M5StickCPlus, AtomLite, AtomMatrix, CoreInk, Tough, Fire.

Original prompt

This section details on the original issue you should resolve

<issue_title>Update nuspec to place library under nano TFM</issue_title>
<issue_description>### Details about task
Most of the nuspec files are not using the correct location to place the files.
Files (DLL, PE, PDBX and XML for IntelliSense) should be placed under "lib\netnano1.0" (currently are being placed under "lib" only.
Also they should declare a dependency group for ".NETnanoFramework1.0" target framework.
At the same time those still naming the various file types should use a wildcard instead (e.g. "...\Release\mscorlib.*).
The correct pattern should be (take this nuspec as sample):
nanoframework/System.Device.Adc@aab7bca

Do not change anything else on the nuspec file.

Work from the DEVELOP branch.

Description

</issue_description>

Comments on the Issue (you are @copilot in this section)


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

@josesimoes josesimoes marked this pull request as ready for review March 11, 2026 15:23
Copilot AI changed the title [WIP] Update nuspec to place library under nano TFM Update nuspec files to place libraries under .NETnanoFramework1.0 TFM Mar 11, 2026
@josesimoes
Copy link
Member

@nfbot updatedependencies develop

@josesimoes josesimoes force-pushed the copilot/update-nuspec-library-location branch from e746908 to 698a1fb Compare March 11, 2026 17:07
@josesimoes josesimoes merged commit 2fd1a4e into develop Mar 11, 2026
3 checks passed
@josesimoes josesimoes deleted the copilot/update-nuspec-library-location branch March 11, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants