fix(applicationsets): stop injecting clusterName/vpcId into bootstrap addons#20
Merged
Merged
Conversation
… addons The addons-bootstrap ApplicationSet passed clusterName + vpcId as Helm --set parameters to every bootstrap addon, but none of them (cert-manager, external-secrets, prometheus-operator-crds, metrics-server, reloader) consume those values — they're for aws-load-balancer-controller in the networking set. cert-manager's chart has a strict values schema (additionalProperties: false), so the unknown parameters made it fail to render with a ComparisonError, leaving it permanently OutOfSync/unsynced. Drop the parameters from the bootstrap template; the addons that genuinely need clusterName/vpcId keep them in their own ApplicationSets.
CI Results
All validations passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
addons-bootstrapApplicationSet passedclusterName+vpcIdas Helm--setparameters to every bootstrap addon, but none of them (cert-manager, external-secrets, prometheus-operator-crds, metrics-server, reloader) consume those values — they're for aws-load-balancer-controller in the networking set. cert-manager's chart has a strict values schema (additionalProperties: false), so the unknown parameters made it fail to render (ComparisonError), leaving it permanently unsynced. Drops the parameters from the bootstrap template.Found standing up a real EKS cluster against this catalog for the first time — cert-manager was the one bootstrap chart with a strict schema.