Skip to content

Update contributing guide instructions#66

Merged
willingc merged 2 commits intonapari:mainfrom
TimMonko:contributing-guide
Apr 16, 2026
Merged

Update contributing guide instructions#66
willingc merged 2 commits intonapari:mainfrom
TimMonko:contributing-guide

Conversation

@TimMonko
Copy link
Copy Markdown
Contributor

No description provided.

@vercel
Copy link
Copy Markdown

vercel Bot commented Sep 10, 2025

@TimMonko is attempting to deploy a commit to the napari Team on Vercel.

A member of the Team first needs to authorize it.

@DragaDoncila
Copy link
Copy Markdown
Contributor

Gah @TimMonko authorizing vercel is annoying because only @Czaki can do it atm (working on it). I've found if you open a PR directly from a repo branch (so push to napari/npe2api not your fork) it deploys without authorization. Can you try that please?

@willingc
Copy link
Copy Markdown
Contributor

@TimMonko @DragaDoncila This PR could likely be merged if Tim takes it out of draft mode. It shouldn't need to be deployed to Vercel as it is the Contributing.md. Probably would make sense in another PR to update the workflow to skip the Vercel step when files not requiring deployment are changed.

@willingc
Copy link
Copy Markdown
Contributor

I'm still unsure why we have a single point of deployment approval 🤷🏼‍♀️

@TimMonko
Copy link
Copy Markdown
Contributor Author

Oh yeah, I guess I never really finished this up because of moving towards the new cloudflare approach. Draga and I were discussing npe2 and npe2api last night and we have plans to change things but its unclear yet where we need to fix things. So maybe for now we do just merge this but I know there are other things that need changed.

@TimMonko TimMonko marked this pull request as ready for review April 16, 2026 16:36
@TimMonko
Copy link
Copy Markdown
Contributor Author

I'm still unsure why we have a single point of deployment approval 🤷🏼‍♀️

We are trying to change this, but are moving away from vercel. The venerable Ashley has done a lot of work to refactor npe2api to use the cloudflare system. https://github.com/aganders3/npe2api
We are still not sure about how and when to make the switch from vercel to cloudflare, as its been a slow project in the background. @willingc if you'd like to contribute to this let us know, right now we are trying to work async but we do meet up the 3 of us (Draga, Ashley, and me) when we can. I'm still like a newborn sheep trying to understand all this though 🙃

@willingc
Copy link
Copy Markdown
Contributor

@willingc if you'd like to contribute to this let us know, right now we are trying to work async but we do meet up the 3 of us (Draga, Ashley, and me) when we can. I'm still like a newborn sheep trying to understand all this though 🙃

Sure, keep me in the loop especially async. I have my personal stuff on Cloudflare and used it at the startup. As I told Draga last week, it's a great choice.

@willingc
Copy link
Copy Markdown
Contributor

I'm going to merge this as is. If it breaks anything, which it shouldn't we can address that separately. Thanks @TimMonko

@willingc willingc merged commit 4068ac5 into napari:main Apr 16, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants