chore: refresh all dependencies and fix wasm32-wasi build#134
Merged
Conversation
Refresh npm, Cargo (via floating ranges) and GitHub Actions versions,
and fix the WASI CI build which was failing on every PR with:
wasm-ld: error: symbol exported via --export not found: emnapi_thread_crashed
Root cause: @napi-rs/cli emitted `--export=emnapi_thread_crashed` while the
pinned emnapi 1.4.5 static lib did not define that symbol. Bumping the napi-rs
toolchain (cli 3.1.3 -> 3.7.3, emnapi 1.4.5 -> 1.11.2) restores the symbol.
npm devDependencies:
- @napi-rs/cli ^3.1.3 -> ^3.7.3
- @napi-rs/lzma ^1.4.4 -> ^1.4.5
- @napi-rs/wasm-runtime ^1.0.3 -> ^1.1.6
- add @emnapi/core ^1.11.2 and @emnapi/runtime ^1.11.2 (now required by the CLI wasi build)
- @types/node ^24 -> ^26, @types/tar ^7.0.0 -> ^7.0.87
- ava ^8.0.0 -> ^8.0.1, chalk ^5.5.0 -> ^5.6.2
- lint-staged ^17.0.0 -> ^17.0.8, npm-run-all2 ^8.0.4 -> ^9.0.2
- oxlint ^1.11.1 -> ^1.73.0, prettier ^3.6.2 -> ^3.9.5
- tar ^7.4.3 -> ^7.5.20 (security), tinybench ^6.0.0 -> ^6.0.2
- typescript ^6.0.0 -> ^6.0.3 (staying on 6.x: TS7 native port breaks yarn's builtin tsserver patch)
GitHub Actions:
- actions/checkout v6 -> v7
- actions/cache v5 -> v6
- cross-platform-actions/action v1.1.0 -> v1.3.0
- wasi-sdk 27 -> 33
index.js / tar.wasi*.js / wasi-worker-browser.mjs regenerated by @napi-rs/cli 3.7.3.
Cargo deps already float to latest (napi 3.10.5, tar 0.4.46, etc.); no Cargo.lock is tracked.
Verified locally: wasm32-wasip1-threads build links and all 22 ava tests pass
under NAPI_RS_FORCE_WASI=1 (with both wasi-sdk 32 and 33), native build + tests
pass, cargo fmt/clippy and oxlint clean.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The build matrix already installs node-version 24 (and the lint/publish jobs run on 24); only the job display name still said node@22. Align the label so build and release both advertise Node.js 24. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 62151b540d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refreshes npm, Cargo and GitHub Actions dependencies, and fixes the WASI CI build that has been failing on every open PR.
Root cause of the WASI failure
The CLI told
wasm-ldto exportemnapi_thread_crashed, but the pinnedemnapi 1.4.5static lib never defined it. Bumping the napi-rs toolchain (@napi-rs/cli3.1.3 → 3.7.3,emnapi1.4.5 → 1.11.2, which defines the symbol) resolves it. The newer CLI alsorequire()s@emnapi/coreat build time, so@emnapi/core+@emnapi/runtimeare now declared as devDependencies.Changes
npm devDependencies
@napi-rs/cli^3.1.3→^3.7.3@napi-rs/lzma^1.4.4→^1.4.5@napi-rs/wasm-runtime^1.0.3→^1.1.6@emnapi/core^1.11.2,@emnapi/runtime^1.11.2(required by the CLI wasi build)@types/node^24→^26,@types/tar^7.0.0→^7.0.87ava^8.0.0→^8.0.1,chalk^5.5.0→^5.6.2lint-staged^17.0.0→^17.0.8,npm-run-all2^8.0.4→^9.0.2oxlint^1.11.1→^1.73.0,prettier^3.6.2→^3.9.5tar^7.4.3→^7.5.20(security),tinybench^6.0.0→^6.0.2typescript^6.0.0→^6.0.3— stays on 6.x on purpose: TypeScript 7 (native/Go port) breaks Yarn's built-intypescriptcompat patch (ENOENT … lib/_tsc.js), which would breakyarn installon every CI job.tscis not in this repo's build/lint/test path.GitHub Actions
actions/checkoutv6 → v7actions/cachev5 → v6cross-platform-actions/actionv1.1.0 → v1.3.0wasi-sdk27 → 33Cargo — already floats to latest via bare-major ranges (
napi3.10.5,tar0.4.46,flate21.1.9, …) and noCargo.lockis tracked, so nothing to bump in the manifest.Generated files —
index.js,tar.wasi.cjs,tar.wasi-browser.js,wasi-worker-browser.mjsregenerated by@napi-rs/cli3.7.3 (native-binding version checks now read1.1.0;tar.wasi.cjsusesrequire.resolve()for the sub-package wasm).Verification (local)
wasm32-wasip1-threadsbuild (wasi-sdk 32 and 33)NAPI_RS_FORCE_WASI=1 yarn testyarn testcargo fmt --check/cargo clippyyarn lint(oxlint)🤖 Generated with Claude Code