feat(pull): show whether anything was pulled - #174
Merged
Conversation
narnaud
reviewed
Jul 7, 2026
narnaud
left a comment
narnaud
left a comment
Owner
There was a problem hiding this comment.
I need to test this change.
The idea of the spinner was to show the user something is happening beyond the hood, without showing all the details. It was particularly important for the git sub-module, many times I thought I had a problem while it was taking some time to download changes with git (and it didn't show anything).
If you pass --no-progress, then we may have the same issue with the first step, no?
I wonder if we could have the spinner showing, and display the output of git just after, once done.
(again, I need to test the change to be sure)
Before: ✓ Fetched latest changes ✓ Rebased onto upstream ✓ Updated submodules ✓ Updated branch wip-stack with origin/master (f7264ed Enforce commit message requirements) After: Total 35 (delta 16), reused 30 (delta 16) From ssh://codereview.kdab.com:29418/kdab/KDABViewer 389626f55..f7264ed16 master -> origin/master ✓ Fetched latest changes ✓ Rebased onto upstream ✓ Updated submodules ✓ Updated branch wip-stack with origin/master (f7264ed Enforce commit message requirements) (plus any new or deleted branches) I need to know that new changes / branches have been pulled. (to know if I need to rebuild; to look at what the cat brought in; etc.)
dfaure-kdab
force-pushed
the
wip/dfaure/pull-output
branch
from
July 8, 2026 11:21
aa0cdde to
0af17b4
Compare
Collaborator
Author
|
OK now with the spinner kept, and the output afterwards. |
Collaborator
Author
|
Tested with a very big submodule update, worked nicely. |
narnaud
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
✓ Fetched latest changes
✓ Rebased onto upstream
✓ Updated submodules
✓ Updated branch wip-stack with origin/master (f7264ed Enforce commit message requirements)
After:
Total 35 (delta 16), reused 30 (delta 16)
From ssh://codereview.kdab.com:29418/kdab/KDABViewer
389626f55..f7264ed16 master -> origin/master
✓ Fetched latest changes
✓ Rebased onto upstream
✓ Updated submodules
✓ Updated branch wip-stack with origin/master (f7264ed Enforce commit message requirements)
(plus any new or deleted branches)
I need to know that new changes / branches have been pulled.
(to know if I need to rebuild; to look at what the cat brought in; etc.)