fix(fold): capture git rebase --continue output instead of leaking it - #179
Open
dfaure-kdab wants to merge 2 commits into
Open
fix(fold): capture git rebase --continue output instead of leaking it#179dfaure-kdab wants to merge 2 commits into
dfaure-kdab wants to merge 2 commits into
Conversation
continue_rebase ran with inherited stdio, so git's own "Successfully rebased" / "Updated the following refs" messages printed to the terminal. Multi-phase folds (e.g. moving a file between commits) called it twice, doubling the noise on top of loom's own success line. Capture the output and route stderr to the trace, matching run_rebase. Fixes narnaud#159
Regression test for narnaud#159: a paused rebase is continued and the trace log must contain the 'rebase --continue' step, which only happens if the command's output is captured rather than inherited.
dfaure-kdab
force-pushed
the
wip/dfaure/fix-159
branch
from
July 17, 2026 15:33
a2c66e7 to
39d5e7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(fold): capture git rebase --continue output instead of leaking it
continue_rebase ran with inherited stdio, so git's own "Successfully
rebased" / "Updated the following refs" messages printed to the
terminal. Multi-phase folds (e.g. moving a file between commits) called
it twice, doubling the noise on top of loom's own success line. Capture
the output and route stderr to the trace, matching run_rebase.
Fixes #159
Claude-Session: https://claude.ai/code/session_01GhTVonYVZ24ZMgNZQLVyAU
test(fold): assert continue_rebase records output to trace
Regression test for #159: a paused rebase is continued and the trace log
must contain the 'rebase --continue' step, which only happens if the
command's output is captured rather than inherited.
Claude-Session: https://claude.ai/code/session_01GhTVonYVZ24ZMgNZQLVyAU