fix(branch): run check-ref-format in a workdir to fix flaky validation - #180
Open
dfaure-kdab wants to merge 1 commit into
Open
fix(branch): run check-ref-format in a workdir to fix flaky validation#180dfaure-kdab wants to merge 1 commit into
dfaure-kdab wants to merge 1 commit into
Conversation
branch_validate_name spawned 'git check-ref-format' without setting the child's cwd, so it inherited the process-global cwd. Git reads cwd even for --branch, so when a parallel test had pointed the process at a temp dir that was later deleted, validating a valid name failed with exit 128 (flaky branch_invalid_name_fails). Pass the caller's workdir through and set current_dir, matching the other git wrappers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
branch_validate_name spawned 'git check-ref-format' without setting the
child's cwd, so it inherited the process-global cwd. Git reads cwd even
for --branch, so when a parallel test had pointed the process at a temp
dir that was later deleted, validating a valid name failed with exit 128
(flaky branch_invalid_name_fails). Pass the caller's workdir through and
set current_dir, matching the other git wrappers.