ci: bump mypy to 2.1.0, pyrefly to 1.0#3639
Merged
Merged
Conversation
MarcoGorelli
commented
May 18, 2026
dangotbanned
requested changes
May 18, 2026
Member
dangotbanned
left a comment
dangotbanned
left a comment
There was a problem hiding this comment.
Thanks for getting the ball rolling on this @MarcoGorelli.
Not sure I had it in me, personally, to take that leap 😅
This is kind of a meta-comment, but AFAICT, your solution to every new diagnostic was cast or # type: ignore?
I would much prefer to use those sparingly and aim to solve some of these guys when possible 🙂
MarcoGorelli
changed the title
dangotbanned
approved these changes
May 19, 2026
Member
dangotbanned
left a comment
dangotbanned
left a comment
There was a problem hiding this comment.
Thanks @MarcoGorelli, looking great 😍
Member
Author
|
thanks for your review! |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What type of PR is this? (check all applicable)
Related issues
Checklist