Skip to content

docs(expr-ir): Explain FunctionExpr#3645

Merged
dangotbanned merged 16 commits into
oh-nodesfrom
expr-ir/docs/functions
May 21, 2026
Merged

docs(expr-ir): Explain FunctionExpr#3645
dangotbanned merged 16 commits into
oh-nodesfrom
expr-ir/docs/functions

Conversation

@dangotbanned
Copy link
Copy Markdown
Member

Description

  • Mainly beefing up the class docstring
  • Removed an entire subclass 😅
  • Sprinkled docs on a few related places too

Related issues

`ExprIR.resolve_dtype` has a partial doc
These are notes
Was a deliberate decision that I don't recall writing about anywhere else
- `polars` *does* allow this in some cases
- but it's simpler to reject like on main
This class was redundant, following the introduction of `Parameters`
Using in an example
Towards #3497
Used 18 times, so this explanation is visible everywhere
Towards #3497
Moved the docs for `HorizontalFunction` here,
since this class doc is visible at the compliant-level
@dangotbanned dangotbanned added documentation Improvements or additions to documentation internal labels May 21, 2026
@dangotbanned dangotbanned marked this pull request as ready for review May 21, 2026 18:43
@dangotbanned dangotbanned mentioned this pull request May 21, 2026
86 tasks
@dangotbanned dangotbanned merged commit 33c8d51 into oh-nodes May 21, 2026
33 of 47 checks passed
@dangotbanned dangotbanned deleted the expr-ir/docs/functions branch May 21, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation internal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant