Skip to content

ogma-core: Move definitions related to ExprPair type to dedicated module. Refs #395.#396

Merged
ivanperez-keera merged 2 commits intonasa:developfrom
ivanperez-keera:develop-exprpair-aux
Apr 16, 2026
Merged

ogma-core: Move definitions related to ExprPair type to dedicated module. Refs #395.#396
ivanperez-keera merged 2 commits intonasa:developfrom
ivanperez-keera:develop-exprpair-aux

Conversation

@ivanperez-keera
Copy link
Copy Markdown
Member

Move types and functions related to the type ExprPair from ogma-core:Command.Common to a new, internal, dedicated module, adjusting imports and uses as appropriate, as prescribed in the solution proposed for #395.

…odule. Refs nasa#395.

The module `ogma-core:Command.Common` exhibits low cohesion.
Specifically, it contain types and functions for abstracting expression
handlers (e.g., `ExprPair`), which are used outside the module. Other
functions in the same module manipulate values of different types,
making the module exhibit low cohesion.

This commit moves the types `ExprPair` and `ExprPairT`, and the function
`exprPair`, from `ogma-core:Command.Common` to a new internal module
`Data.ExprPair`, adjusting imports and uses as necessary.
@ivanperez-keera
Copy link
Copy Markdown
Member Author

Change Manager: Verified that:

@ivanperez-keera ivanperez-keera merged commit 5f066cd into nasa:develop Apr 16, 2026
6 checks passed
@ivanperez-keera ivanperez-keera deleted the develop-exprpair-aux branch April 16, 2026 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant