ogma-core: Move definitions related to ExprPair type to dedicated module. Refs #395.#396
Merged
ivanperez-keera merged 2 commits intonasa:developfrom Apr 16, 2026
Merged
Conversation
…odule. Refs nasa#395. The module `ogma-core:Command.Common` exhibits low cohesion. Specifically, it contain types and functions for abstracting expression handlers (e.g., `ExprPair`), which are used outside the module. Other functions in the same module manipulate values of different types, making the module exhibit low cohesion. This commit moves the types `ExprPair` and `ExprPairT`, and the function `exprPair`, from `ogma-core:Command.Common` to a new internal module `Data.ExprPair`, adjusting imports and uses as necessary.
Member
Author
|
Change Manager: Verified that:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move types and functions related to the type
ExprPairfromogma-core:Command.Commonto a new, internal, dedicated module, adjusting imports and uses as appropriate, as prescribed in the solution proposed for #395.