Param build by Pherring04 · Pull Request #2034 · nasa/trick

Pherring04 · 2026-02-02T23:55:03Z

Implemented parameterized build directory for sim builds.

coveralls · 2026-02-04T14:54:14Z

Coverage is 56.135% — ParamBuild into master. No base build found for master.

…the process too. You're welcome.

brendan-nasa · 2026-07-21T22:13:25Z

+    makefile_io_src << " \\\n    $(TRICK_BUILD_DIR)build/class_map.o" << std::endl
+                    << std::endl
+                    << "$(IO_OBJECTS): \%.o : \%.cpp | \%.d" << std::endl
+                    << "\t$(PRINT_COMPILE)" << std::endl
+                    << "\t$(call ECHO_AND_LOG,$(TRICK_CXX) $(TRICK_CXXFLAGS) $(TRICK_SYSTEM_CXXFLAGS) "
+                       "$(TRICK_IO_CXXFLAGS) -MMD -MP -c -o $@ $<)"
+                    << std::endl
+                    << std::endl
+                    << "$(IO_OBJECTS:.o=.d): ;" << std::endl
+                    << std::endl
+                    << "-include $(IO_OBJECTS:.o=.d)" << std::endl
+                    << std::endl
+                    << "$(S_MAIN): $(IO_OBJECTS)" << std::endl
+                    << std::endl
+                    << "LINK_LISTS += $(LD_FILELIST)" + trick_build_dir + "build/io_link_list" << std::endl;


I know this is what was already here but since we're touching it...

endl does a "\n" << std::flush but we shouldn't need to flush at all in this

Suggested change

makefile_io_src << " \\\n $(TRICK_BUILD_DIR)build/class_map.o" << std::endl

<< std::endl

<< "$(IO_OBJECTS): \%.o : \%.cpp | \%.d" << std::endl

<< "\t$(PRINT_COMPILE)" << std::endl

<< "\t$(call ECHO_AND_LOG,$(TRICK_CXX) $(TRICK_CXXFLAGS) $(TRICK_SYSTEM_CXXFLAGS) "

"$(TRICK_IO_CXXFLAGS) -MMD -MP -c -o $@ $<)"

<< std::endl

<< std::endl

<< "$(IO_OBJECTS:.o=.d): ;" << std::endl

<< std::endl

<< "-include $(IO_OBJECTS:.o=.d)" << std::endl

<< std::endl

<< "$(S_MAIN): $(IO_OBJECTS)" << std::endl

<< std::endl

<< "LINK_LISTS += $(LD_FILELIST)" + trick_build_dir + "build/io_link_list" << std::endl;

makefile_io_src << " \\\n"

" $(TRICK_BUILD_DIR)build/class_map.o\n"

"\n"

"$(IO_OBJECTS): %.o : %.cpp | %.d\n"

"\t$(PRINT_COMPILE)\n"

"\t$(call ECHO_AND_LOG,$(TRICK_CXX) $(TRICK_CXXFLAGS) $(TRICK_SYSTEM_CXXFLAGS) $(TRICK_IO_CXXFLAGS) -MMD -MP -c -o $@ $<)\n"

"\n"

"$(IO_OBJECTS:.o=.d): ;\n"

"\n"

"-include $(IO_OBJECTS:.o=.d)\n"

"\n"

"$(S_MAIN): $(IO_OBJECTS)\n"

"\n"

"LINK_LISTS += $(LD_FILELIST)" << trick_build_dir << "build/io_link_list\n";

brendan-nasa · 2026-07-21T22:13:49Z

        std::string ssrc = (*mit).second.substr(0,found) ;
        if(ssrc.substr( ssrc.length()-11, ssrc.length()) != "io_S_source" )
        {
+            // TODO: class_map.o appears to be missing?


brendan-nasa · 2026-07-21T22:14:22Z

+    /*if( std::getenv("AM_I_TRICKIFYING") && std::getenv("AM_I_TRICKIFYING_MK") ) {
+        trickifying    = true;
+        trickifying_mk = true;
+        std::ifstream trickify_deps("build/trickify/swig/fake_deps_map") ;
+        if ( !trickify_deps.fail() ) {
+            std::string in_left;
+            std::string in_right;
+            while ( std::getline(trickify_deps, in_left, ':') && std::getline(trickify_deps, in_right) ) {
+                trickify_src_deps_map.push_back(in_left);
+                std::cout << "<<<<<<<<<<<<<<<<<<<<<< " << in_left << std::endl;
+                std::cout << "<<<<<<<<<<<<<<<<<<<<<< " << in_left << std::endl;
+                std::cout << "<<<<<<<<<<<<<<<<<<<<<< " << in_left << std::endl;
+                std::cout << "<<<<<<<<<<<<<<<<<<<<<< " << in_left << std::endl;
+                std::cout << "<<<<<<<<<<<<<<<<<<<<<< " << in_left << std::endl;
+                std::cout << ">>>>>>>>>>>>>>>>>>>>>> " << in_right << std::endl;
+                std::cout << ">>>>>>>>>>>>>>>>>>>>>> " << in_right << std::endl;
+                std::cout << ">>>>>>>>>>>>>>>>>>>>>> " << in_right << std::endl;
+                std::cout << ">>>>>>>>>>>>>>>>>>>>>> " << in_right << std::endl;
+                std::cout << ">>>>>>>>>>>>>>>>>>>>>> " << in_right << std::endl;
+                trickify_src_deps_map.push_back(in_right);
+            }
+        }
+        else {
+            char cwd[PATH_MAX];
+
+            if (getcwd(cwd, sizeof(cwd)) != nullptr) {
+            } else {
+                perror("getcwd() error");
+            }
+            std::cout << "build/trickify/swig/fake_deps_map no exist =(, " << cwd << std::endl;
+        }
+    }
+    else
+    {
+        std::cout << "NO AM_I_TRICKIFYING_MK!" << std::endl;
+    }*/


that's a lot of commented out code

brendan-nasa · 2026-07-21T22:14:47Z

+        if (!found)
+        {
+            // std::cout << "|" << header_file_name << "|" << std::endl;
+            // return false;
+        }


empty branch

brendan-nasa · 2026-07-21T22:16:45Z

+    if (std::getenv("TRICK_EXCLUDE"))
+    {
+        char* env = std::getenv("TRICK_EXCLUDE");
+    }
+    if (std::getenv("TRICK_ICG_EXCLUDE"))
+    {
+        char* env = std::getenv("TRICK_ICG_EXCLUDE");
+    }


where are these used?

brendan-nasa · 2026-07-21T22:25:51Z

+ifneq ($(wildcard build/),build/trickify/swig/fake_deps_paths)
+	TRICKIFY_FAKE_DEP_PATHS := $(shell cat build/trickify/swig/fake_deps_paths)
+endif


I think this comparison always evaluates to true

wildcard build/ is either build/ or empty; neither of which equal build/trickify/swig/fake_deps_paths

Suggested change

ifneq ($(wildcard build/),build/trickify/swig/fake_deps_paths)

TRICKIFY_FAKE_DEP_PATHS := $(shell cat build/trickify/swig/fake_deps_paths)

endif

ifneq ($(wildcard build/trickify/swig/fake_deps_paths),)

TRICKIFY_FAKE_DEP_PATHS := $(shell cat build/trickify/swig/fake_deps_paths)

endif

brendan-nasa · 2026-07-21T22:37:52Z

-    } elsif ($arg eq "-C" || $arg eq "--directory" ) {
-        $sdefine_dir = abs_path($ARGV[$argnum + 1]);
+    }
+    elsif ( $arg eq "-C" || $arg eq "--directory" ) {


I think these changes (along with line 70) break -C option

easier to see without formatting changes included in the diff here:

https://github.com/nasa/trick/pull/2034/changes/BASE..908f9758377209bebd0ae7014cc9fff2bdc48361#diff-f717c5406f106d99dfe400f36ca2b58ebb4919f5c1cf45a315127f4cd261cdc6L25-R64

brendan-nasa · 2026-07-21T22:41:28Z

+#if defined(_WIN32)
+#include <direct.h>
+#define get_current_dir _getcwd
+#else
+#include <unistd.h>
+#define get_current_dir getcwd
+#endif


what's the problem

what, do we suddenly NOT support 32-bit Windows?? When did that stop?

brendan-nasa · 2026-07-22T00:08:50Z

            continue;
        }

+        std::string path = almostRealPath(header_file_name.c_str());


leaks a malloc'd char* from almostRealPath()

Suggested change

std::string path = almostRealPath(header_file_name.c_str());

char* resolved_path = almostRealPath(header_file_name.c_str());

if (resolved_path == NULL) {

continue;

}

const std::string path = std::string(resolved_path);

free(resolved_path);

Pherring04 added 4 commits February 2, 2026 17:35

Implemented trick_build_dir parameter

811904b

Merge master

e5707f3

Fixed a few bugs

a8d5d10

Fixed bug

01eb796

Pherring04 and others added 11 commits February 4, 2026 15:52

Removed the egregious double semi-colon. Probably saved the world in …

63c1edf

…the process too. You're welcome.

Bug fix

1efcd06

Implemented multiple trickified libraries

1245c51

Merging master

0794d92

checkpoint

fd52ebd

Modularized make_makefile_swig

e5a300f

Lots of stuff

2f02c5d

Merge branch 'master' into ParamBuild

908f975

Formatting

c5d5a6a

More formatting

610ba13

More formatting

f238030

brendan-nasa reviewed Jul 22, 2026

View reviewed changes

-        std::string path = almostRealPath(header_file_name.c_str());
+        char* resolved_path = almostRealPath(header_file_name.c_str());
+        if (resolved_path == NULL) {
+            continue;
+        }
+        const std::string path = std::string(resolved_path);
+        free(resolved_path);

Uh oh!

Conversation

Pherring04 commented Feb 2, 2026

Uh oh!

coveralls commented Feb 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brendan-nasa Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brendan-nasa Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coveralls commented Feb 4, 2026 •

edited

Loading

brendan-nasa Jul 21, 2026 •

edited

Loading

brendan-nasa Jul 21, 2026 •

edited

Loading