Skip to content

CLI Request: [Firewall rules]: Firewall rules create operation failing for allowAll firewall rule #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nasc17 wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

CLI Request: [Firewall rules]: Firewall rules create operation failing for allowAll firewall rule #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/azure-cli/azure/cli/command_modules/rdbms/_helptext_pg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,10 @@
Create a firewall rule allowing connections to all Azure services
text: >
az postgres flexible-server firewall-rule create --resource-group testGroup --name testserver --rule-name allowazureservices --start-ip-address 0.0.0.0
- name: >
Create a firewall rule allowing connections to all IP addresses. This may be insecure.
text: >
az postgres flexible-server firewall-rule create --resource-group testGroup --name testserver --rule-name allowall --start-ip-address 0.0.0.0
"""

helps['postgres flexible-server firewall-rule list'] = """
Expand Down
7 changes: 7 additions & 0 deletions src/azure-cli/azure/cli/command_modules/rdbms/flexible_server_custom_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,13 @@ def firewall_rule_create_func(cmd, client, resource_group_name, server_name, fir
logger.warning('Configuring server firewall rule to accept connections from \'%s\' to \'%s\'...', start_ip_address,
end_ip_address)

if firewall_rule_name == 'allowall':
start_ip_address = '0.0.0.0'
end_ip_address = '255.255.255.255'
now = datetime.now()
firewall_rule_name = 'AllowAll_{}-{}-{}_{}-{}-{}'.format(now.year, now.month, now.day, now.hour, now.minute, now.second)
logger.warning('Configuring server firewall rule to accept connections from \'%s\' to \'%s\'...', start_ip_address, end_ip_address)

parameters = {
'name': firewall_rule_name,
'start_ip_address': start_ip_address,
Expand Down