Add support for tags

[playfulkittykat]

Here's my attempt at adding support for tags. It isn't entirely complete yet, but I wanted to get your opinion before moving forward.

I've gone with a builder pattern for tags::Query, but differently than PoolSearch. If you like it, I can update everything to the same style.

Outstanding Tasks:

• verify Cursor logic
• mockito tests
• better documentation for tags::Query (and everything else.)
• more examples

[nasso]

thank you!

i like the Cursor and the Query API seems nice. we can work on making it more consistent with PoolSearch in a separate PR to make things easier

i am not familiar with the tag search API (it didn't exist back then) so i dont know much about the a1234 and b1234 bits

[playfulkittykat]

i like the Cursor and the Query API seems nice. we can work on making it more consistent with PoolSearch in a separate PR to make things easier

Thank you! That works for me

i am not familiar with the tag search API (it didn't exist back then) so i dont know much about the a1234 and b1234 bits

It looks like it uses the same code path as the posts endpoint, so the a... and b... should be similar to:

rs621/src/post.rs

Lines 388 to 392 in 236bac4

	match this.next_page {
	SearchPage::Page(i) => format!("{}", i),
	SearchPage::BeforePost(i) => format!("b{}", i),
	SearchPage::AfterPost(i) => format!("a{}", i),
	},

[playfulkittykat]

I'm happy with where this is now. Let me know what you think!

[nasso]

pretty cool! looking mostly good to me, just minor nitpicks (also minor conflicts)

regarding the mocked data (in tests and json files), i'd prefer using SFW data, please 😅

[nasso]

Suggested change

	Self::Page(p) => write!(f, "{}", p),
	Self::Before(p) => write!(f, "b{}", p),
	Self::After(p) => write!(f, "a{}", p),
	Self::Page(p) => write!(f, "{p}"),
	Self::Before(p) => write!(f, "b{p}"),
	Self::After(p) => write!(f, "a{p}"),

[playfulkittykat]

Should I also add rust-version = "1.58" to Cargo.toml?

[nasso]

oh maybe, i didn't check what the msrv is

[playfulkittykat]

Looks like it'd be around 1.70 because of some dependencies.

[nasso]

yeah that seems okay to be honest?

[playfulkittykat]

I've added Cargo.lock to the repository (see here for the general reasoning) specifically because I've added 1.70 to GitHub Actions, and if a dependency changes its rust-version, that would cause CI to randomly break.