Open
Conversation
…lternates Author: Zevaryx <zevaryx@gmail.com>
Owner
|
Oh my god I just realised I wasn't watching the repository for some reason so I was never notified of your pull request. My bad. I will take a look as soon as I can! |
Author
|
No worries! I actually forgot about this PR, so not a big deal |
nasso
requested changes
Mar 15, 2022
| } | ||
|
|
||
| #[derive(Debug, PartialEq, Eq, Deserialize)] | ||
| pub struct PostSampleAlternates { |
Owner
There was a problem hiding this comment.
It should probably be singular: PostSampleAlternate
nElzky
approved these changes
Apr 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning
The API now has a field inside of
samplecalledalternates. This field is usually empty, but is filled when there are different resolution sizes for a sample for videos. See post 2474986 for a rating:s sample. Additionally, with an update between when I first started this patch and now, they added it so every post now has this field (see post 39 for a rating: example of it being applied to an extremely old post).Solution
An extra struct (
PostSampleAlternates) and an extra field (alternates) allow for proper handling of this.Example usage: