Open
Conversation
added 2 commits
January 8, 2016 16:13
Added an option for a “media query,” so that the script won’t run when the viewport is a smaller width than a specified width.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an option for a “media query,” so that the script won’t run when the viewport is a smaller width than a specified width.
When using the script on a
h2with thenbspoption with a particularly wide webfont, I found that the script could unintentionally force some text to extend wider than the viewport, adding a horizontal scrollbar on mobile.Would need to be re-minified.