Group sparkle and welcome text on the onboarding screen#49
Merged
Conversation
The previous layout left the AutoAwesome icon stretched across the upper region (fillMaxSize, bottom-padded 192dp) and pinned the welcome text to BottomCenter, producing a large empty gap on tall phones -- substrate review flagged this as a "broken layout" with the title "jammed at the very bottom of the screen". Restructure to a Column with weighted spacers and a fixed 220dp sparkle so icon and title sit together in the upper-middle, mirroring the iOS welcome composition. Mirrors NativeAppTemplate-Android#63. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Substrate review flagged the welcome screen as a broken layout: the AutoAwesome icon used
fillMaxSize(stretched across the upper region) and the welcome text was pinned toBottomCenter, producing a large empty gap between them on tall phones — the title looked "jammed at the very bottom of the screen". iOS gets away with the same ZStack-style structure because SwiftUI's resizable Image and platform typography produce a tighter visual cluster; Compose'sIcon+BottomCentertext doesn't.Restructure to a
Columnwith weighted spacers and a fixed-size 220dp sparkle so the icon and title sit together in the upper-middle, matching the iOS visual composition.Mirrors NativeAppTemplate-Android#63.
Test plan
./gradlew :app:assembleDebugsucceeds./gradlew spotlessKotlinCheckpasses🤖 Generated with Claude Code