Fix invisible sparkle on welcome and sign-up screens in light mode#50
Merged
Fix invisible sparkle on welcome and sign-up screens in light mode#50
Conversation
The welcome screen used theme-following surfaces with a hard-coded white sparkle and white-derived text — in light display mode the sparkle became white-on-white and the screen looked broken. Pin the welcome screen to the brand navy (#1A2332, same as the launcher and splash) regardless of theme so the white sparkle and title always have contrast, extending the launcher/splash look into the first screen the user sees. The sign-up/sign-in screen still follows the system theme since it has chrome (buttons, links) that should match the rest of the app, so swap its sparkle tint from hard-coded white to MaterialTheme.colorScheme.primary so it's visible in both light and dark modes. Mirrors NativeAppTemplate-Android#65. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In light display mode the welcome screen rendered the white sparkle on a near-white themed background — the sparkle disappeared and the screen looked empty. Pin the welcome screen to the brand navy
#1A2332(same as the launcher icon background and splash) regardless of theme, so the white sparkle and title always have contrast. This also extends the launcher/splash visual identity into the first screen the user sees.The sign-up/sign-in screen stays theme-following (it has chrome — buttons, terms link — that should match the rest of the app), so its sparkle tint moves from hard-coded
Color.WhitetoMaterialTheme.colorScheme.primaryto keep contrast in both modes.Mirrors NativeAppTemplate-Android#65.
Test plan
./gradlew :app:assembleDebugsucceeds./gradlew spotlessKotlinCheckpasses🤖 Generated with Claude Code