Remove vestigial code from NFC/Scan removal#56
Merged
dadachi merged 1 commit intosubstrate-v2from Apr 29, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirror of upstream nativeapptemplate/NativeAppTemplate-iOS#67, adapted to this fork.
Summary
Cleanup of dead code left behind after the NFC/QR/Scan feature was removed:
CustomerScannedTagview — zero call sites, only referenced itself. Drop the correspondingcustomerScannedTag{Background,Border,Foreground}colors fromColor+Extensions.swiftand the file refs fromproject.pbxproj.preparingTag{Background,Border,Foreground}colors — no view ever referenced them; vestigial from an older item-state hierarchy.MainButtonView.swift: remove a 3-line dead comment about a Scan-tab accessibility workaround that no longer applies.CodedError.swift: remove the NFC mention from the error-code range comment; no error type uses that range anymore.Net diff: 5 files, −78 / +1. No behavior change, no public API touched, no tests modified.
Test plan
make lintpassesxcodebuild ... build-for-testingsucceeds (iPhone 17, iOS 26.4.1)IdlingTag/CompletedTagcorrectlyNotes
IdlingTagwas almost deleted because the file is namedIdlingTagView.swiftwhile the struct is namedIdlingTag— the initial grep missed callers. VerifiedIdlingTag()is referenced fromShopDetailCardView,ItemTagListCardView, andItemTagDetailViewand kept intact.🤖 Generated with Claude Code