Cleanup: dead Date helper, swiftier String predicates, README env vars#59
Merged
dadachi merged 3 commits intosubstrate-v2from Apr 30, 2026
Merged
Conversation
- Drop unused cardTimeAgoInWordsDateString and its timeAgoInWordsDateFormatter - Move isBlank and validateEmail from Utility static helpers to String computed-property extensions (isBlank, isValidEmail) and update all call sites in production and tests - Fold UtilityTest cases into StringExtensionsTest and delete UtilityTest - README: clarify that Xcode is in practice the only NATEMPLATE_API_* env var injector, so the hardcoded fallbacks are what keep Debug builds working when launched from SpringBoard or after Xcode disconnects Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The Beta config has no shared scheme and isn't referenced by CI, README, or any xcconfig — drop it from the pbxproj so the project only ships Debug and Release. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…eric The String.image(...) renderer and both isAlphanumeric() overloads have no production callers — only their own tests reference them. Drop the helpers and their tests; UIKit/Foundation imports collapse to Foundation since the remaining isBlank / isValidEmail need only that. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cardTimeAgoInWordsDateStringand itstimeAgoInWordsDateFormatter.isBlankandvalidateEmailfromUtilitystatic helpers toStringcomputed-property extensions (isBlank,isValidEmail) — boolean assertions read more naturally on the receiver per Apple's API Design Guidelines. Updated all production and test call sites; folded the oldUtilityTestcases intoStringExtensionsTestand removedUtilityTest.swift.NATEMPLATE_API_*env var injector, so the hardcoded fallbacks are what keep Debug builds working when launched from SpringBoard or after Xcode disconnects.Ports the documented changes from upstream PR https://github.com/nativeapptemplate/NativeAppTemplate-iOS/pull/70.
Test plan
make lint— 0 violations, 0 formatting issuesBUILD SUCCEEDEDString.isBlank,String.isValidEmail, and the touched ViewModels (SignUp,SignIn,ForgotPassword,ResendConfirmation, etc.)🤖 Generated with Claude Code