Normalize substrate naming: drop NATI-/NATEMPLATE_API_ abbreviations#60
Merged
dadachi merged 1 commit intosubstrate-v2from May 1, 2026
Merged
Conversation
- Env vars: NATEMPLATE_API_{SCHEME,DOMAIN,PORT} -> NATIVEAPPTEMPLATE_API_*
in Constants.swift and README.md
- Error codes: NATI-XXXX -> NATIVEAPPTEMPLATE-XXXX across production and
test Swift files, plus CHANGELOG.md
- CLAUDE.md: error-code section reframed as a shared iOS+Android prefix;
dropped the stale NFCError.swift / NATIVEAPPTEMPLATE-3xxx row (file no
longer present in this fork)
Mirrors upstream PR nativeapptemplate/NativeAppTemplate-iOS#71.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eliminate the two abbreviations the upstream agent's Layer 1 renamer can't reach so
NativeAppTemplate -> <slug>covers every product-name occurrence. Mirrors upstream PR nativeapptemplate/NativeAppTemplate-iOS#71.NATEMPLATE_API_{SCHEME,DOMAIN,PORT}->NATIVEAPPTEMPLATE_API_*inConstants.swift,README.md, and the local.xcscheme(gitignored, updated locally)NATI-XXXX->NATIVEAPPTEMPLATE-XXXXacross all production and test Swift files, plusCHANGELOG.mdNFCError.swift/NATIVEAPPTEMPLATE-3xxxrow (file is not present in this fork)After this lands,
rg -n "NATEMPLATE_API|NATI-"outsidedocs-private/matches nothing.Test plan
make lint(0 violations, SwiftFormat clean)xcodebuild build(Debug, iPhone 17 Pro / iOS 26.2) succeedsxcodebuild testforAppErrorTest,CodedErrorTest,NativeAppTemplateAPIErrorTest,MessageBusTest, and the four touched ViewModel tests — all passNATIVEAPPTEMPLATE_API_DOMAIN, etc.) in the Xcode scheme — the oldNATEMPLATE_API_*names will no longer be picked up🤖 Generated with Claude Code