docs: remove the deploy lifecycle page after the topic split#700
Open
khuyentran1401 wants to merge 5 commits into
Open
docs: remove the deploy lifecycle page after the topic split#700khuyentran1401 wants to merge 5 commits into
khuyentran1401 wants to merge 5 commits into
Conversation
The deploy.mdx page had been reduced to pointer sections by the topic split, so delete it and drop it from the sidebar. Repoint the Hetzner provider's deploy/verify/destroy links to the per-topic pages, and drop the now-removed What every deployment includes reference from the AWS and Hetzner pages.
✅ Deploy Preview for nebari-docs2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
andrewfulton9
left a comment
andrewfulton9
left a comment
Collaborator
There was a problem hiding this comment.
This looks good to me. I like the wording changes. I'll let @marcelovilla give the final approval though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues or PRs
Fixes #698. Depends on #697 and #699 (this branch is stacked on them).
What does this implement/fix?
Testing
Confirmed no internal links point to
/docs/how-tos/deployanymore (onlydeploy-cluster). Note: this branch is stacked on #697 and #699, so the diff currently includes the Cloudflare DNS and Keycloak pages; once those merge, it reduces to the deploy page removal.