You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Related to numeric input, could RNW also support min, max and step? I know they don't exist in RN but they'd simply be ignore there. I can add it to this PR or create a separate one.
@necolas Fair enough. Would you be instead okay with adding web-only type, min, max, and step props to enable explicitly enforcing specific browser behavior when the developer chooses to do so?
I don't think so, as that would puncture the API and allow completely different results to be produced on web.
You can either implement that functionality cross platform in JS, or use the unstable_createElement API to create a custom web element using those props, and decide where to fork/recombine that with your RN code in your product.
But this is a relevant issue for future xplat react APIs, as it surfaces more limitations of RN's TextInput API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Numeric/decimal keyboardType should also set type=number to allow only numeric keys on desktop and mobile.