Fix memory leak with Animated API#2800
Merged
necolas merged 1 commit intonecolas:masterfrom Aug 20, 2025
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b8d3c9e:
|
This was referenced Aug 20, 2025
Closed
Owner
|
Yeah patching this is a good idea. I don't know of a good way to keep Animated up to date given the effort to make the RN Animated available as an installable package has stalled. |
Owner
|
Out in 0.21.1 |
Contributor
Author
|
Thanks for the quick reaction! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While working with
@react-navigationpackage I noticed a leak that was leaving multipleDetached <div>instances in the memory while usingAnimated APIon web. They were never garbage collected.After a week-long investigation I finally found the root cause for the problem. It turned out that
_animatedViewinstance was never set tonull, even after detaching the element. It turned out that this problem has already been solved in thereact-nativerepository. But sincereact-native-webuses an older version of React Native it was not reflected in thevendordirectory.My suggestion is to
cherry-pickthis solution also to some other versions ofreact-native-web(to v19 and v20), since I noticed it there, too.