Provide environment variables in configuration settings if present in…#226
Open
ZachWatkins wants to merge 2 commits into
Open
Provide environment variables in configuration settings if present in…#226ZachWatkins wants to merge 2 commits into
ZachWatkins wants to merge 2 commits into
Conversation
Owner
|
Hmm I'm not sure why the workflows haven't run |
Owner
|
@ZachWatkins I know this is a late response but I've been extremely busy recently but would you be able to take a look at adding some unit tests for these additions. In general I'm happy with what you are wanting to change we may want to think about where some of the code should sit. I did think that replacement set of classes might even be a good idea to implement where we do more of this sort of thing. That shouldn't change the implementation of the unit tests though so let's look at getting those covered first. |
Author
|
@neild3r OK I will see about adding those tests, I'm glad you responded and no worries about the response time. I don't have an ETA but I will find time to add tests and send them your way.
Zachary Watkins
…________________________________
From: Neil Brayfield ***@***.***>
Sent: Friday, November 11, 2022 7:21:50 AM
To: neild3r/vscode-php-docblocker ***@***.***>
Cc: Zachary K. Watkins ***@***.***>; Mention ***@***.***>
Subject: Re: [neild3r/vscode-php-docblocker] Provide environment variables in configuration settings if present in… (PR #226)
@ZachWatkins<https://github.com/ZachWatkins> I know this is a late response but I've been extremely busy recently but would you be able to take a look at adding some unit tests for these additions.
In general I'm happy with what you are wanting to change we may want to think about where some of the code should sit. I did think that replacement set of classes might even be a good idea to implement where we do more of this sort of thing.
That shouldn't change the implementation of the unit tests though so let's look at getting those covered first.
—
Reply to this email directly, view it on GitHub<#226 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AA2MOO5LAALYWYPIKSWABYTWHZB65ANCNFSM536MFB6Q>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… process.env
Change Summary:
[ What have you changed and why? ]
I have changed the extension to allow user configurations to include
${env:myVariable}in tag content definitions which will be replaced with environment variables available to the extension at runtime usingprocess.env. This will be useful for automatic inclusion of a PHP project's version number which can be more easily automated as an environment variable than it can as a VS Code setting. Without this change I have to manually input the project's current version number for@sinceand@versiontags. This also allows me to define more tag content at the User-level such as@copyrightand@packageby setting it to${env:PACKAGE_NAME}and ensuring the directory provides this environment variable before VS Code starts.Checks:
CHANGELOG.mdupdated with relevant changes