Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion course-04/exercises/lesson-6/solution/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"aws-serverless-express": "^3.3.6",
"aws-xray-sdk": "^2.3.3",
"elasticsearch": "^15.5.0",
"express": "^4.17.1",
"express": "^4.22.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The package.json is updated to version 4.22.1, but the package-lock.json still reflects the old version 4.17.1. This can lead to inconsistent dependency installation across environments and may prevent the security fixes from being applied. Please run npm install to update the package-lock.json and commit the changes.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since this project uses TypeScript, it's a best practice to include type definitions for your dependencies. This improves code quality, enables better static analysis, and enhances developer experience with autocompletion. While updating express, please also add its type definitions to devDependencies.

You can do this by running:

npm install --save-dev @types/express

"http-aws-es": "^6.0.0",
"jimp": "^0.6.4",
"jsonwebtoken": "^8.5.1",
Expand Down