Skip to content

[Snyk] Upgrade axios from 0.27.2 to 0.30.0 #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nejidevelops wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Snyk] Upgrade axios from 0.27.2 to 0.30.0 #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"@ngneat/transloco": "^4.1.0",
"@nrwl/angular": "^14.4.2",
"@types/googlemaps": "^3.43.3",
"axios": "^0.27.2",
"axios": "^0.30.0",

@gemini-code-assist gemini-code-assist Bot Jun 15, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Upgrading axios to ^0.30.0 is a positive step for addressing the listed security vulnerabilities.

However, it's important to be aware of potential breaking changes. The release notes for axios v0.30.0 (included in this PR's description) explicitly mention a fix related to a breaking change in an intermediate version:

fix: modify upgrade guide for 0.28.1's breaking change

This refers to axios v0.28.1, which is between your old version (0.27.2) and the new version (0.30.0). The specific breaking change in v0.28.1 concerned the handling of FormData objects with GET, HEAD, or DELETE requests. You can find more details in the Axios v0.x Upgrade Guide.

While the Snyk metadata for this PR states "isBreakingChange": false, this discrepancy with the official release notes warrants careful attention.

Recommendations:

  • Review Upgrade Guides: Consult the axios upgrade guides for all versions between 0.27.2 and 0.30.0, paying particular attention to the v0.28.1 changes.
  • Thorough Testing: Conduct comprehensive testing of all application parts that utilize axios. Since axios is also listed in firebase-functions-dependencies, ensure backend functionality remains unaffected. This is crucial to catch any regressions or unexpected behavior before merging.

Taking these precautions will help ensure a smooth and safe upgrade.

"crypto-js": "^4.1.1",
"firebase-admin": "^11.0.0",
"firebase-functions": "^3.22.0",
Expand Down