Skip to content

fix: accept raw artifact upload signatures#6099

Open
puneetdixit200 wants to merge 1 commit into
nektos:masterfrom
puneetdixit200:fix-artifact-v6-raw-signature
Open

fix: accept raw artifact upload signatures#6099
puneetdixit200 wants to merge 1 commit into
nektos:masterfrom
puneetdixit200:fix-artifact-v6-raw-signature

Conversation

@puneetdixit200
Copy link
Copy Markdown

Fixes #6021.

Summary

  • emit artifact v4 upload/download signatures with raw base64url encoding so generated signed URLs do not depend on = padding
  • keep accepting existing padded signatures for compatibility
  • add regression coverage for unpadded artifact upload signatures

Tests

  • GOMODCACHE=$PWD/.gomodcache GOCACHE=$PWD/.gocache go test ./pkg/artifacts -run 'TestArtifactV4' -count=1\n- GOMODCACHE=$PWD/.gomodcache GOCACHE=$PWD/.gocache go test -short ./pkg/artifacts -count=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Artifact server: Error unauthorized on blob upload with upload-artifact@v6

1 participant