Skip to content

docs: update compatibility matrix#102

Merged
nvitucci merged 13 commits into
mainfrom
conn-986-quick-doc-tidy-up-fixes-for-spark
Jun 25, 2026
Merged

docs: update compatibility matrix#102
nvitucci merged 13 commits into
mainfrom
conn-986-quick-doc-tidy-up-fixes-for-spark

Conversation

@fbiville

Copy link
Copy Markdown
Contributor

Include an appendix with older versions too.

@ali-ince ali-ince left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just had two small comments.

Comment thread modules/ROOT/pages/compatibility.adoc Outdated
Comment thread modules/ROOT/pages/compatibility.adoc Outdated

@nvitucci nvitucci left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before continuing with other comments, I think it would make more sense to either just have only one compatibility table for both Neo4j and Python/Scala versions, or have two tables but in the same page. This will make updates easier in the future, both for introducing new versions and to set a given version as EOL.

Comment thread modules/ROOT/pages/installation.adoc Outdated
Comment thread modules/ROOT/pages/installation.adoc Outdated
@nord-erik nord-erik force-pushed the conn-986-quick-doc-tidy-up-fixes-for-spark branch from 235ac75 to 3b84a60 Compare June 24, 2026 13:54
@nord-erik

Copy link
Copy Markdown
Contributor

In the latest revision, I moved all compatibility tables into one page.

Then instead of in-lining them in e.g. installation.adoc I simply reference to it.

This creates one page that should hold the single source of truth

@nord-erik nord-erik requested a review from nvitucci June 24, 2026 13:56
@nord-erik

Copy link
Copy Markdown
Contributor

Please re-review when you have time @nvitucci

@nord-erik nord-erik force-pushed the conn-986-quick-doc-tidy-up-fixes-for-spark branch 2 times, most recently from 26b7bda to 531db6b Compare June 24, 2026 14:46
Comment thread modules/ROOT/pages/compatibility.adoc Outdated
Comment thread modules/ROOT/pages/compatibility.adoc Outdated
Comment thread modules/ROOT/pages/compatibility.adoc Outdated
Comment thread modules/ROOT/pages/compatibility.adoc Outdated
fbiville and others added 10 commits June 24, 2026 17:54
Include an appendix with older versions too.
We have some granular support requirements for spark versions,
previous version looked like all 5.x connectors supported all spark.
this fixes the review comments

Co-authored-by: Nicola Vitucci <nicola.vitucci@neo4j.com>
Co-authored-by: Florent Biville <445792+fbiville@users.noreply.github.com>
Co-authored-by: Florent Biville <445792+fbiville@users.noreply.github.com>
@nord-erik nord-erik force-pushed the conn-986-quick-doc-tidy-up-fixes-for-spark branch from a76c6db to 1dfb8eb Compare June 24, 2026 15:54

@nvitucci nvitucci left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few changes for spelling and clarity

Comment thread modules/ROOT/pages/compatibility.adoc Outdated
Comment thread modules/ROOT/pages/compatibility.adoc Outdated
Comment thread modules/ROOT/pages/compatibility.adoc Outdated
Comment thread modules/ROOT/pages/faq.adoc Outdated
Comment thread modules/ROOT/pages/index.adoc Outdated
Comment thread modules/ROOT/pages/index.adoc Outdated
Comment thread modules/ROOT/pages/installation.adoc Outdated
Co-authored-by: Nicola Vitucci <nicola.vitucci@gmail.com>
Comment thread modules/ROOT/pages/installation.adoc Outdated
Comment thread modules/ROOT/pages/index.adoc Outdated
Comment thread modules/ROOT/pages/compatibility.adoc Outdated
Co-authored-by: Nicola Vitucci <nicola.vitucci@gmail.com>
@neo4j-docops-agent

neo4j-docops-agent commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@nvitucci nvitucci merged commit 89b2ce3 into main Jun 25, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants