fix: use fetched embedding property in vector cypher retriever#541
Open
liuzemei wants to merge 1 commit into
Open
fix: use fetched embedding property in vector cypher retriever#541liuzemei wants to merge 1 commit into
liuzemei wants to merge 1 commit into
Conversation
Signed-off-by: Sheldon <neooosky@gmail.com>
stellasia
reviewed
Jul 8, 2026
| self.result_formatter = validated_data.result_formatter | ||
| self._node_label = None | ||
| self._node_embedding_property = None | ||
| self._embedding_node_property = None |
| filters={"organization": {"$eq": "neo4j"}}, | ||
| ) | ||
|
|
||
| expected_query, search_params = get_search_query( |
Contributor
There was a problem hiding this comment.
Not sure I understand what this test is doing. It's never testing that the property was properly populated (_fetch_index_info is moched) and it's also never testing the actual query being generated?
Contributor
|
Hey @liuzemei , To be able to merge your changes we will need a signed CLA from you. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_embedding_node_propertyforVectorCypherRetrieverfiltered fallback queriesFixes #540
Tests
uv run pytest tests/unit/retrievers/test_vector.py::TestVectorCypherRetrieverSearchClausePath::test_filtered_fallback_uses_fetched_embedding_property -quv run pytest tests/unit/retrievers/test_vector.py -quv run pytest tests/unit/retrievers/test_base.py tests/unit/retrievers/test_hybrid.py tests/unit/retrievers/test_retriever_parameter_inference.py tests/unit/retrievers/test_text2cypher.py tests/unit/retrievers/test_tools_retriever.py tests/unit/retrievers/test_vector.py -quv run ruff format --check src/neo4j_graphrag/retrievers/vector.py tests/unit/retrievers/test_vector.pyuv run ruff check src/neo4j_graphrag/retrievers/vector.py tests/unit/retrievers/test_vector.pygit diff --check