refactor(llm): extract shared http_client sync/async split helper#564
Closed
matteomedioli wants to merge 1 commit into
Closed
refactor(llm): extract shared http_client sync/async split helper#564matteomedioli wants to merge 1 commit into
matteomedioli wants to merge 1 commit into
Conversation
matteomedioli
marked this pull request as draft
July 16, 2026 23:15
AnthropicLLM, OpenAILLM, and AzureOpenAILLM each carried an identical ~10-line dance to route an httpx.Client/httpx.AsyncClient http_client kwarg to the matching SDK client, warning and dropping it otherwise. Factored into one split_http_client_kwargs helper in llm/utils.py, used by all three, so future subclasses (e.g. Aura-hosted variants) don't need a fourth/fifth copy of the same logic. Pure refactor, no behavior change.
matteomedioli
force-pushed
the
matteo/split-http-client-helper-GENKGB-1658
branch
from
July 16, 2026 23:17
07da65c to
a7a85a7
Compare
matteomedioli
changed the base branch from
matteo/base-anthropic-llm-GENKGB-1658
to
matteo/anthropic-kwargs-bugfix-GENKGB-1658
July 16, 2026 23:17
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.