Make driver's default SSL context respect SSLKEYLOGFILE env var#1312
Draft
robsdedude wants to merge 2 commits into
Draft
Make driver's default SSL context respect SSLKEYLOGFILE env var#1312robsdedude wants to merge 2 commits into
robsdedude wants to merge 2 commits into
Conversation
This aligns the driver with Python's `ssl.create_default_context()` behavior: > When `keylog_filename` is supported and the environment variable > `SSLKEYLOGFILE` is set, `create_default_context()` enables key logging. > > -- https://docs.python.org/3/library/ssl.html#ssl.create_default_context The same behavior could previously be achieved by passing a custom SSLContext. However, this is much more work. Supporting the env var `SSLKEYLOGFILE` is a common practice for software using SSL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aligns the driver with Python's
ssl.create_default_context()behavior:The same behavior could previously be achieved by passing a custom SSLContext. However, this is much more work. Supporting the env var
SSLKEYLOGFILEis a common practice for software using SSL.Closes: DRIVERS-442