[5.28] Cache sockname and peername#1313
Open
robsdedude wants to merge 3 commits into
Open
Conversation
Async ----- Instead of relying on asyncio's caching of these properties, we do it ourselves. The advantage is that asyncio populates the cache on a best-effort basis. This can lead to the values being `None` if retrieving them causes an `OSError`. This is a misalignment between the async and sync driver that this PR aims to remedy. Sync ---- While in then async driver we're introducing (custom) caching where implicit caching was already in place, we also introduce caching of these fields in the sync driver for parity.
robsdedude
force-pushed
the
fix/own-sockname-caching
branch
from
b60baef to
f1ec1fa
Compare
Contributor
AndyHeap-NeoTech
left a comment
AndyHeap-NeoTech
left a comment
There was a problem hiding this comment.
Looks good, just one small comment for clarification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Async
Instead of relying on asyncio's caching of these properties, we do it ourselves. The advantage is that asyncio populates the cache on a best-effort basis. This can lead to the values being
Noneif retrieving them causes anOSError.This is a misalignment between the async and sync driver that this PR aims to remedy.
Sync
While in the async driver we're introducing (custom) caching where implicit caching was already in place, we also introduce caching of these fields in the sync driver for parity.
Fixes: #1310
Part of: DRIVERS-418