Conversation
Replace all hardcoded English strings in the wow module with get_string() lookups. Migrate _NOTIFICATION_STRINGS dict to YAML locale files. Remove per-command language parameters from armory, guildnews setup, and guildnews edit — the guild language preference from GuildLanguageConfig is now the single source of truth for both API locale and UI strings. Background polls dynamically look up the guild language instead of using a stored per-config Language field. Co-Authored-By: Claude <noreply@anthropic.com>
karaktaka
force-pushed
the
feat/i18n-wow
branch
from
17d563b to
7ae924d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_string()/get_guild_language()lookups (29 keys)_NOTIFICATION_STRINGSdict to YAML locale files for consistency with the rest of the i18n systemlanguageparameters from/wow armory,/wow guildnews setup, and/wow guildnews edit— the guild language fromGuildLanguageConfigis now the single source of truth for both API locale and UI stringsLanguagefieldcheck) stays in English per conventiontests/modules/test_wow_locale.pyTest plan
uv run python -m pytest)ruff checkandruff format --checkclean🤖 Generated with Claude Code