feat(i18n): localize application module responses#247
Merged
Conversation
Migrate all hardcoded English strings in the application module, views, and conversations to use the get_string()/get_guild_language() infrastructure. Modal titles are localized per-interaction; persistent view button labels stay in English (single instance serves all guilds). Co-Authored-By: Claude <noreply@anthropic.com>
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Built-in template names and questions are now resolved from YAML locale files at use-time based on the guild's language setting. DB keeps English names as stable identifiers; TEMPLATE_KEY_MAP bridges to YAML keys. - Add get_raw() to utils/strings.py for non-string YAML lookups - Add builtin_templates section to lang_en.yaml and lang_de.yaml - Localize _template_autocomplete, _template_list, _template_use - Add TEMPLATE_KEY_MAP for English DB name → YAML key mapping Co-Authored-By: Claude <noreply@anthropic.com>
karaktaka
force-pushed
the
feat/i18n-application
branch
from
729dcba to
c8cd02e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
application.py,views/application.py, andconversations/application.pyto useget_string()/get_guild_language()infrastructurelang_en.yamlandlang_de.yamlcovering commands, review embeds, modal titles, apply button, and error messagesVote,Edit Vote,Message,Override,Apply) stay in English since a single instance serves all guildstest_application_locale.pywith 53 EN/DE tests covering cog commands, view buttons, modal titles, and embed builderstest_application_view.py, integration tests) to work with newget_string()calls by addingload_strings()fixtures andguild_idmock attributesTest plan
ruff checkandruff format --checkclean🤖 Generated with Claude Code