chore(apollo): upgrade apollo client dependencies#2916
Closed
erikwrede wants to merge 2 commits intonestjs:masterfrom
Closed
chore(apollo): upgrade apollo client dependencies#2916erikwrede wants to merge 2 commits intonestjs:masterfrom
erikwrede wants to merge 2 commits intonestjs:masterfrom
Conversation
erikwrede
commented
Jul 11, 2023
Comment on lines
+39
to
+44
| onConnect: ( | ||
| context: Context< | ||
| any, | ||
| { socket: { close: (number, string) => any | boolean } } | ||
| >, | ||
| ) => { |
Contributor
Author
There was a problem hiding this comment.
Did this to fix the typescript errors, if anyone can point me towards the right type that is used here, I'm happy to adjust this line, IMO using any, just like upstream, here is sufficient for the tests though.
Contributor
Author
|
@kamilmysliwiec any chance to get a review on this? 😊 |
1 task
|
@erikwrede looks like a conflict that can block the release of this. |
Contributor
Author
|
@bel7aG since this is a dependency upgrade the package lock is changing a lot. If @kamilmysliwiec gives an okay I can update the lock immediately. Otherwise, there's little sense in updating the lock every week without feedback, given the frequent renovate dependency updates. |
Member
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #2911
What is the new behavior?
This PR fixes the issues described in #2911 by upgrading the outdated apollo client to a much newer version. The issue was not caused by an upstream bug, but by outdated dev dependencies incomatible with current prod dependencies.