fix(cli): fix treating path args as flags#3467
Open
QusaiAlbonni wants to merge 1 commit into
Open
Conversation
QusaiAlbonni
force-pushed
the
fix/remaining-flags-skip-non-flag-args
branch
from
63d64fc to
04d2e30
Compare
Member
|
can you create a second PR with the same set of changes targeting v12 branch as well? #3280 ideally, we would have an e2e test for this in that branch too |
Author
QusaiAlbonni
force-pushed
the
fix/remaining-flags-skip-non-flag-args
branch
from
04d2e30 to
010fdec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #3466
What is the new behavior?
getRemainingFlagsnow returns an empty array for when no flags exist, also when values are checked for if they already exist as an option in commander it will now only check flags rather than everything which falsly checks paths and values leading to errors like the one in the issueDoes this PR introduce a breaking change?
Other information