Skip to content

fix: loosen gRPC DNS error message assertion in test_client_error #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfiedorowicz merged 1 commit into from
Apr 16, 2026
+1 −1
Merged

fix: loosen gRPC DNS error message assertion in test_client_error #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ def test_client_error(mock_diode_authentication):
)
client.ingest(entities=[])
assert err.value.status_code == grpc.StatusCode.UNAVAILABLE
assert "DNS resolution failed for invalid:8081" in err.value.details
assert "invalid:8081" in err.value.details


def test_diode_client_error_repr_returns_correct_string():
Expand Down
Loading