Skip to content

Fix MSBuild property syntax for Windows CI #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aaronontheweb merged 1 commit into from
May 5, 2026
+18 −18
Merged

Fix MSBuild property syntax for Windows CI #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/pr_validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,8 @@ jobs:
-c Release \
-r linux-x64 \
--self-contained \
/p:PublishSingleFile=true \
/p:TrimmerSingleWarn=false \
-p:PublishSingleFile=true \
-p:TrimmerSingleWarn=false \
-o ./publish/linux-x64

- name: "Check trim warnings"
Expand All @@ -154,12 +154,12 @@ jobs:
-c Release \
-r linux-x64 \
--self-contained \
/p:PublishSingleFile=true \
/p:TrimmerSingleWarn=false \
/p:TreatWarningsAsErrors=true \
/warnAsError:IL2026 /warnAsError:IL2057 \
/warnAsError:IL2067 /warnAsError:IL2075 \
/warnAsError:IL2096 /warnAsError:IL3050
-p:PublishSingleFile=true \
-p:TrimmerSingleWarn=false \
-p:TreatWarningsAsErrors=true \
-warnAsError:IL2026 -warnAsError:IL2057 \
-warnAsError:IL2067 -warnAsError:IL2075 \
-warnAsError:IL2096 -warnAsError:IL3050

- name: "Smoke test"
run: |
Expand Down
20 changes: 10 additions & 10 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
run: ./build.ps1

- name: "Pack"
run: dotnet pack /p:PackageVersion=${{ github.ref_name }} -c Release -o ./output
run: dotnet pack -p:PackageVersion=${{ github.ref_name }} -c Release -o ./output

- name: "Upload artifacts"
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a
Expand Down Expand Up @@ -108,10 +108,10 @@ jobs:
-c Release \
-r ${{ matrix.rid }} \
--self-contained \
/p:PublishSingleFile=true \
/p:Version=${{ env.VERSION }} \
/p:AssemblyVersion=${{ env.ASSEMBLY_VERSION }} \
/p:FileVersion=${{ env.ASSEMBLY_VERSION }} \
-p:PublishSingleFile=true \
-p:Version=${{ env.VERSION }} \
-p:AssemblyVersion=${{ env.ASSEMBLY_VERSION }} \
-p:FileVersion=${{ env.ASSEMBLY_VERSION }} \
-o ./publish

- name: "Smoke test"
Expand Down Expand Up @@ -187,11 +187,11 @@ jobs:
run: |
dotnet publish src/SkillServer/SkillServer.csproj \
-c Release \
/t:PublishContainer \
/p:ContainerRegistry=${{ env.CONTAINER_REGISTRY }} \
/p:ContainerRepository=${{ env.CONTAINER_IMAGE }} \
/p:ContainerRuntimeIdentifier=${{ matrix.rid }} \
/p:ContainerImageTags='"${{ github.ref_name }}-${{ matrix.arch }}"'
-t:PublishContainer \
-p:ContainerRegistry=${{ env.CONTAINER_REGISTRY }} \
-p:ContainerRepository=${{ env.CONTAINER_IMAGE }} \
-p:ContainerRuntimeIdentifier=${{ matrix.rid }} \
-p:ContainerImageTags='"${{ github.ref_name }}-${{ matrix.arch }}"'

# ─── Stage 2: Publish everything once all builds succeed ─────────────

Expand Down
Loading