Fix unbound variable error in install script#60
Merged
Aaronontheweb merged 1 commit intodevfrom May 5, 2026
Merged
Conversation
Move tmp_dir from local function scope to script scope so the EXIT trap can reference it after main() returns. With set -u (nounset), the local variable was out of scope when the trap fired.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tmp_dirfrom local function scope to script-levelTMP_DIRso the EXIT trap can reference it aftermain()returnsset -u(nounset), the local variable was out of scope when the trap fired, causing an "unbound variable" error on exitTest plan
install-skillserver.shlocally — installsskillserver 0.3.0cleanly with no errorsskillserver --versionworks after install