Cache Petri net functions after import

[machacjozef]

Added a call to cache all Petri net functions immediately after importing a Petri net. This ensures that all relevant functions are available and improves the runtime performance for subsequent operations.

Description

<Fixes [JIRA-ISSUE]>/<Implements [JIRA-ISSUE]>

Dependencies

Third party dependencies

• <Name of a new library/dependency link to the new library> - <Reason, why it was added to the project> /

Blocking Pull requests

<Depends on #(PR id)>/

How Has Been This Tested?

• <Name of a test [test file](link to the test file)>

Test Configuration

<Please describe configuration for tests to run if applicable, like program parameters, host OS, VM configuration etc.>

Name	Tested on
OS
Runtime
Dependency Manager
Framework version
Run parameters
Other configuration

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• My changes have been checked, personally or remotely, with @...
• I have commented my code, particularly in hard-to-understand areas
• I have resolved all conflicts with the target branch of the PR
• I have updated and synced my code with the target branch
• I have added tests that prove my fix is effective or that my feature works
• New and existing tests pass locally with my changes:
  • Lint test
  • Unit tests
  • Integration tests
• I have checked my contribution with code analysis tools:
  • SonarCloud
  • Snyk
• I have made corresponding changes to the documentation:
  • Developer documentation
  • User Guides
  • Migration Guides

Summary by CodeRabbit

• Chores
  • Optimized PetriNet import performance by implementing immediate function caching during save operations, improving subsequent access times and application responsiveness.

[coderabbitai]

Walkthrough

A call to cache all PetriNet functions is added to PetriNetService, executing immediately after successfully importing and saving a Petri net. This ensures cached functions are refreshed during the import process.

Changes

Cohort / File(s)	Summary
PetriNet Function Caching application-engine/src/main/java/com/netgrif/application/engine/petrinet/service/PetriNetService.java	Added functionCacheService.cacheAllPetriNetFunctions() call after Petri net import to refresh the function cache.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• [NAE-2369] Remove global functions of cache #410: Modifies PetriNet function caching strategy (eviction on delete vs. refresh on import).

Suggested labels

Medium

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Cache Petri net functions after import' directly and clearly summarizes the main change: adding a caching call for Petri net functions after importing.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

application-engine/src/main/java/com/netgrif/application/engine/petrinet/service/PetriNetService.java (1)

192-202: 🧹 Nitpick | 🔵 Trivial

Avoid a full cache rebuild before the net is persisted

cacheAllPetriNetFunctions() runs before doSaveInternal, so if it rebuilds from the repository it won’t include the just-imported net; you already cache the new net at Line 202. This makes the new call redundant and potentially expensive on every import. Consider moving it after the save (or drop it if cachePetriNetFunctions is sufficient).

Suggested move

-        functionCacheService.cacheAllPetriNetFunctions();
         runActionAndPublishEvent(outcome, null, newProcess.getPreUploadActions(), importPetriNetParams.getParams(),
                 new ProcessDeployEvent(outcome, EventPhase.PRE));
@@
         Optional<PetriNet> saveProcessOpt = doSaveInternal(newProcess);
         functionCacheService.cachePetriNetFunctions(newProcess);
+        functionCacheService.cacheAllPetriNetFunctions();