Enable ambiguous-function-call mago rule#12
Closed
Scarbous wants to merge 1 commit into
Closed
Conversation
Fully-qualify the three global function calls (defined, get_class, iterator_to_array) that were resolved ambiguously at compile time, so the ambiguous-function-call linter rule can be turned on instead of disabled.
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ambiguous-function-calllint rule was disabled inmago.toml. It flags unqualified calls to global functions that PHP can't resolve at compile time (preventing an optimization), recommending a leading\or ause functionimport instead.defined()inAbstractNodeProcessor::getNodePath(), andget_class()/iterator_to_array()in the unit tests — and re-enabled the rule.Test plan
vendor/bin/mago lint --only ambiguous-function-call src/ tests/reports no issuesvendor/bin/phpunit --testdox --testsuite unitpasses (49 tests, 1 pre-existing skip unrelated to this change)🤖 Generated with Claude Code