feat(node-ci): add enable-type-check and enable-gitleaks toggles#249
Merged
Conversation
Plain-JS packages have no type/build layer (type-check would need a no-op hack) and repos without a GITLEAKS_LICENSE would fail the gitleaks job. Both are now opt-out via inputs (default true), so the node gold standard fits plain-JS consumers cleanly. Signed-off-by: Sebastian Mendel <sebastian.mendel@netresearch.de>
|
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
enable-type-checkandenable-gitleaksinputs (default true) tonode-ci.ymlso plain-JS consumers (no type/build layer; no GITLEAKS_LICENSE) adopt the gold standard cleanly instead of via atrueno-op / a failing gitleaks job.ts-check.ymlalready exposesenable-type-check.