feat: tool@cycle make targets (make uninstall-node@24)#112
Merged
Conversation
make install-/upgrade-/uninstall-<tool>@<cycle> now dispatches through scripts/cycle_action.sh, which maps the cycle to the dedicated installer's version env var (NODE_VERSION, RUBY_VERSION, GO_VERSION, UV_PYTHON_SPEC) — no more remembering per-tool env var names. Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #112 +/- ##
=======================================
Coverage 72.59% 72.59%
=======================================
Files 22 22
Lines 3416 3416
=======================================
Hits 2480 2480
Misses 936 936
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NODE_VERSION=24 make uninstall-nodeworks but requires knowing each tool's env var name (NODE_VERSIONvsRUBY_VERSIONvsUV_PYTHON_SPEC). The audit output speaks in cycles (node@24,ruby@3.3) — the make targets now do too:make uninstall-node@24,make uninstall-ruby@3.3,make upgrade-go@1.26,make install-python@3.13install-%/upgrade-%/uninstall-%branch to a newscripts/cycle_action.shwhen the stem contains@; it maps tool → version env var and execs the dedicated installer (node, ruby, go, python — the four multi-version runtimes with dedicated scripts)php@8.4) and malformed specs get clear errorsmake uninstall-ripgrep) unchanged (pinned by test)Tests
tests/test_cycle_targets.py(10 tests): dispatcher env mapping for all four runtimes, unsupported-tool and malformed-spec errors,make -nintegration for all three verbs, plain-target regression guardmake uninstall-ruby@3.1→ per-cycle path, clean "not found" no-op