chore: document installer invariants, wire shell tests into CI#113
Merged
Conversation
scripts/AGENTS.md gains the four invariants behind this week's fixes (no PATH-lookup verification, environments are not installations, stdin-detached quiet wrappers, whole-file shellcheck hook). tests/test_guide_multi_install.sh and tests/test_reconcile_dryrun.sh ran in no CI job; a dormant assertion there predicted the nvm/npm classification bug fixed in #106. New Shell Tests job runs both. Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
=======================================
Coverage 72.59% 72.59%
=======================================
Files 22 22
Lines 3416 3416
=======================================
Hits 2480 2480
Misses 936 936
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retro follow-ups from this week's bug chain (#106–#111):
scripts/AGENTS.md— four hard-won invariants, each of which caused a shipped bug: never verify installs via PATH lookup (resolve the manager's bin dir; pass detected paths into removal code), environments ≠ installations (both detection layers must stay in sync), quiet command wrappers detach stdin and surface failures, and the shellcheck hook lints the whole changed file.Shell Testsjob runningtests/test_guide_multi_install.sh(52 assertions) andtests/test_reconcile_dryrun.sh(7 assertions) — they were wired into no job, and a dormant assertion in the former (classify nvm path returns npm(...)) predicted the pnpm/nvm misclassification fixed in fix(scripts): remove all detected installations on uninstall #106 long before it bit.Both suites verified green locally before wiring.
Came from /retro: yes