chore(ci): route lint job through python-ci.yml, drop duplicate security job#116
Merged
Conversation
…ity job - lint: fold the inline flake8 + mypy job into the org-standard python-ci.yml reusable (run-lint + run-type-check, tests off), matching how the test job already calls it. Removes this workflow's inline checkout + setup-python for linting. - security: remove the inline bandit + pip-audit job — it duplicated security.yml, which already runs both via the shared python-audit.yml reusable on push/PR/schedule. flake8 keeps its blocking + exit-zero passes; mypy stays non-blocking. build/docs/integration-e2e remain bespoke (build, README/YAML checks, CLI e2e) with no reusable equivalent, so their setup-python stays inline. Signed-off-by: Sebastian Mendel <sebastian.mendel@netresearch.de>
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
=======================================
Coverage 72.59% 72.59%
=======================================
Files 22 22
Lines 3416 3416
=======================================
Hits 2480 2480
Misses 936 936
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Continues moving this repo's CI onto the shared
netresearch/.githubreusables (thetestandsecurity.ymljobs already use them):lint→ folds the inline flake8 + mypy job intopython-ci.yml@main(run-lint+run-type-check, tests off), mirroring how thetestjob already calls it. flake8 keeps both passes (blocking select +--exit-zerocomplexity); mypy stays non-blocking (|| true).security→ removed. It duplicatedsecurity.yml, which already runs bandit + pip-audit via the sharedpython-audit.ymlreusable on push/PR/schedule.Removes this workflow's inline
checkout+setup-pythonfor both jobs (-55 / +22).Why
actions/setup-pythonwas pinned inline in every job, so Renovate opened a per-repo bump PR (#115 was the latest). Routing jobs through reusables maintains those pins once innetresearch/.github.Not centralized (bespoke — no reusable fits)
build(wheel + twine),docs(README/YAML checks),integration-e2e(CLI e2e), andshell-testskeep their inline steps —python-ci.ymlcan't express them without misusing its lint/type/test toggles. Theirsetup-pythonstays inline, so Renovate will still bump those. Centralizing them would need a new generic "python-command" reusable innetresearch/.github— happy to author one as a follow-up if wanted.Independent
Uses
python-ci.yml@main, already live — no dependency on netresearch/.github#243.