Skip to content

chore(ci): pilot python-app-ci gold-standard reusable#119

Merged
CybotTM merged 4 commits into
mainfrom
chore/adopt-python-app-ci
Jul 21, 2026
Merged

chore(ci): pilot python-app-ci gold-standard reusable#119
CybotTM merged 4 commits into
mainfrom
chore/adopt-python-app-ci

Conversation

@CybotTM

@CybotTM CybotTM commented Jul 21, 2026

Copy link
Copy Markdown
Member

What

Pilot the new python-app-ci.yml gold-standard meta-reusable from netresearch/.github on this repo.

One app-ci call now composes:

  • python-ci — lint (flake8) + type-check (mypy, non-blocking) + tests (pytest + coverage)
  • python-buildpython -m build + twine check
  • python-audit — pip-audit + bandit + CycloneDX SBOM
  • gitleaks — secret scanning
  • dependency-review — on PRs

This replaces the former separate lint / test / build reusable-call jobs in ci.yml and the audit job in security.yml (deleted). Bespoke jobs shell-tests, docs, integration-e2e are kept unchanged as siblings.

Reference pinning

The meta is pinned to netresearch/.github@feat/python-gold-standard (not yet on main). Flip to @main after netresearch/.github#252 merges.

Input mapping (repo commands → meta inputs)

Meta input Value
package-manager pip
python-versions ["3.14"]
os-versions ubuntu + macos + windows (preserves the prior cross-OS test matrix)
install-cmd pip install -r requirements-dev.txt
lint-cmd the repo's existing flake8 command
type-check-cmd mypy cli_audit --ignore-missing-imports || true (kept non-blocking)
test-cmd the repo's existing unit + integration pytest command
enable-build true (python -m build / twine check dist/*)
run-bandit true (matches prior default)
enable-gitleaks true (org GITLEAKS_LICENSE available)
enable-codeql false — repo uses CodeQL default setup (actions + python); enabling the advanced workflow would conflict

Pilot findings / notes for reviewers

  1. Coverage upload gate mismatch (meta gap). The meta does not expose coverage-os / coverage-python-version; the underlying python-ci.yml defaults coverage-python-version to 3.13. This repo is 3.14-only, so the Codecov upload gate never matches and coverage will not upload despite coverage-upload: true. Recommend the meta forward those two inputs (or default the coverage cell to the first matrix entry).
  2. Dropped weekly schedule. The deleted security.yml ran the audit on a weekly cron (0 6 * * 1) in addition to push/PR. The meta/ci.yml runs on push/PR only. If the weekly scheduled audit should be preserved, add a schedule: trigger to ci.yml or keep a slimmed schedule-only security.yml.
  3. Combining lint/type/test into one matrixed ci job means flake8 + mypy now also run on macOS/windows cells (previously ubuntu-only); tests already ran on all three.

Do not merge

Pilot only. No branch-protection changes (repo has no required status checks configured).

Replace the separate lint/test/build reusable-call jobs in ci.yml and the
audit job in security.yml with one call to the python-app-ci meta-reusable
(lint/type/test + build + audit + gitleaks + dependency-review). Bespoke
jobs (shell-tests, docs, integration-e2e) are kept as siblings.

CodeQL stays off (repo uses CodeQL default setup). Pinned to
@feat/python-gold-standard until netresearch/.github#252 merges; flip to
@main afterwards.

Signed-off-by: Sebastian Mendel <sebastian.mendel@netresearch.de>
Copilot AI review requested due to automatic review settings July 21, 2026 06:15
@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

  • .github/workflows/security.yml

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

CybotTM added 3 commits July 21, 2026 08:19
Signed-off-by: Sebastian Mendel <sebastian.mendel@netresearch.de>
Signed-off-by: Sebastian Mendel <sebastian.mendel@netresearch.de>
Signed-off-by: Sebastian Mendel <sebastian.mendel@netresearch.de>
@sonarqubecloud

Copy link
Copy Markdown

@CybotTM
CybotTM merged commit 1e12651 into main Jul 21, 2026
24 checks passed
@CybotTM
CybotTM deleted the chore/adopt-python-app-ci branch July 21, 2026 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants