Skip to content

docs: flake-vs-regression triage + git show cross-branch reads#101

Merged
CybotTM merged 3 commits into
mainfrom
feat/retro-shard-triage-and-git-show
Jul 16, 2026
Merged

docs: flake-vs-regression triage + git show cross-branch reads#101
CybotTM merged 3 commits into
mainfrom
feat/retro-shard-triage-and-git-show

Conversation

@CybotTM

@CybotTM CybotTM commented Jul 16, 2026

Copy link
Copy Markdown
Member

Summary

Two reference additions from a /retro session: how to tell a one-shard-red CI failure apart (flake vs. real regression), and reading a file as committed on another branch without checkout.

Came from

/retro session on 2026-07-16 (timetracker release/deploy work).

  • Symptom: A red E2E (1/4) was dismissed as a boot-flake twice; the second run was a real regression a .field-check-row restyle had introduced (a spec's getByText-anchored .check() hung 30s). Separately, a phantom "file was modified" reminder after a branch switch nearly sent me chasing a non-edit.
  • Cause: No documented heuristic for flake-vs-regression on sharded suites; and trusting the working-tree copy right after git checkout instead of the object store.
  • Required behavior: Read the shard's first error (boot line = collateral flake; same specs across all shards = real bug; locator.check timeout = actionability regression). Use git show <branch>:<path> to read committed state across branches.

Change

  • merge-gate-watcher.md: new "One shard red: flake vs. real regression" section.
  • advanced-git.md: new "Reading a File As It Is Committed on Another Branch" section.

Test plan

  • Build/Scripts/validate-skill.sh — 0 errors, 0 warnings
  • Commands verified (git show <ref>:<path>, git diff A B -- path, gh run rerun <id> --failed)
  • Both commits signed + DCO signed-off

Copilot AI review requested due to automatic review settings July 16, 2026 19:49
@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation for git workflows and merge gate monitoring. It adds a guide on reading files from the object store using 'git show' and provides criteria for distinguishing between infrastructure flakes and real regressions in sharded test suites. The review comments suggest clarifying the scope of 'git diff' for file comparisons and refining the definition of 'real regressions' to better accommodate single-shard Playwright failures.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread skills/git-workflow/references/advanced-git.md Outdated
Comment thread skills/git-workflow/references/merge-gate-watcher.md Outdated
CybotTM added a commit that referenced this pull request Jul 16, 2026
…tion

Gemini review on #101: `git diff <A> <B> -- <path>` compares a file, not the
whole tree — reword and add `-- <path>` to the three-dot example. And the
"real regression fails across all shards" line tensioned with the single-shard
Playwright case — mark it the typical case, with the Playwright exception.

Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
CybotTM added a commit that referenced this pull request Jul 16, 2026
…tion

Gemini review on #101: `git diff <A> <B> -- <path>` compares a file, not the
whole tree — reword and add `-- <path>` to the three-dot example. And the
"real regression fails across all shards" line tensioned with the single-shard
Playwright case — mark it the typical case, with the Playwright exception.

Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
@CybotTM
CybotTM force-pushed the feat/retro-shard-triage-and-git-show branch from 3679e6e to 32d6147 Compare July 16, 2026 20:27
CybotTM added 3 commits July 16, 2026 22:31
…ession

A /retro session (2026-07-16) found a red `E2E (1/4)` dismissed as a boot
flake twice — correct once, but the second run was a real regression. Add a
section on reading the shard's first error: a stack-boot/health-check line at
the top means collateral failures below (infra flake, rerun); the same specs
failing across all shards means a real bug. Notes the Playwright
`locator.check: Test timeout` = actionability tell for a broken hit target.

Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
Add `git show <branch>:<path>` for inspecting a file's committed content on
another ref without checkout. A /retro session (2026-07-16) hit a phantom
"file was modified" after a branch switch — the on-disk copy reflected the
landed branch, not the one being reasoned about. Reading from the object store
is authoritative.

Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
…tion

Gemini review on #101: `git diff <A> <B> -- <path>` compares a file, not the
whole tree — reword and add `-- <path>` to the three-dot example. And the
"real regression fails across all shards" line tensioned with the single-shard
Playwright case — mark it the typical case, with the Playwright exception.

Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
@CybotTM
CybotTM force-pushed the feat/retro-shard-triage-and-git-show branch from 32d6147 to 824f8d8 Compare July 16, 2026 20:31
@sonarqubecloud

Copy link
Copy Markdown

@CybotTM
CybotTM enabled auto-merge July 16, 2026 20:31
@CybotTM
CybotTM merged commit da228e1 into main Jul 16, 2026
17 checks passed
@CybotTM
CybotTM deleted the feat/retro-shard-triage-and-git-show branch July 16, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants